build: upgrade MetalLB to v0.15.2 and use helm upgrade --install#4330
Conversation
- Update MetalLB version from 0.13.12 to 0.15.2 in kind and minikube makefiles - Change from 'helm install' to 'helm upgrade --install' for better idempotency - This allows the command to work on both fresh installs and upgrades
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the MetalLB Helm chart version from 0.13.12 to 0.15.2 and switches from helm install to helm upgrade --install for idempotent deployments across both minikube and kind test clusters.
- Upgraded MetalLB Helm chart from version 0.13.12 to 0.15.2
- Changed deployment command from
helm installtohelm upgrade --installfor better idempotency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build/includes/minikube.mk | Updated MetalLB installation command for minikube clusters with new version and helm upgrade pattern |
| build/includes/kind.mk | Updated MetalLB installation command for kind clusters with new version and helm upgrade pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Build Succeeded 🥳 Build Id: 603206ae-b8ee-4cb3-9d0f-f10d94e96561 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
lacroixthomas
left a comment
There was a problem hiding this comment.
Good idea about the helm upgrade --install !
LGTM !
…nes-dev#4330) - Update MetalLB version from 0.13.12 to 0.15.2 in kind and minikube makefiles - Change from 'helm install' to 'helm upgrade --install' for better idempotency - This allows the command to work on both fresh installs and upgrades
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A