test: fix flaky TestPortRangeAllocatorSyncDeleteGameServer#4399
Merged
markmandel merged 2 commits intoDec 27, 2025
Merged
Conversation
Fixing the race condition that an event may not have fired even though Agones client list operations may be returning the correct list values. Utilised `Eventually` and `Never` to ensure we tested for eventual final states. Closes agones-dev#4390
Collaborator
|
Build Succeeded 🥳 Build Id: 02ff7fd2-3273-4e7b-bb27-a9af1c5d6cf3 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
Collaborator
|
Build Failed 😭 Build Id: 48359fc9-574f-43ba-a29c-541461d6652e Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Member
Author
|
New flake? /gcbrun |
Collaborator
|
Build Failed 😭 Build Id: 5a4a6153-eb0e-4106-8534-9ddc1153cc57 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Collaborator
|
Seen that yesterday locally, I have set a timeout way too short, like 50ms 😅 |
Member
Author
|
Doh. TestControllerGameServersNodeState. I have a fix for this one locally, I need to do a quick review for it and get it up. /gcbrun |
Collaborator
|
Build Succeeded 🥳 Build Id: 4131bddb-e066-437d-bc6f-ca56fac6a5b8 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
mnthe
pushed a commit
to mnthe/agones
that referenced
this pull request
Mar 23, 2026
…v#4399) Fixing the race condition that an event may not have fired even though Agones client list operations may be returning the correct list values. Utilised `Eventually` and `Never` to ensure we tested for eventual final states. Closes agones-dev#4390
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Fixing the race condition that an event may not have fired even though Agones client list operations may be returning the correct list values.
Utilised
EventuallyandNeverto ensure we tested for eventual final states, as well as making some small test improvements along the way.Which issue(s) this PR fixes:
Closes #4390
Special notes for your reviewer:
I ran this 200 times with no issues.
@Sivasankaran25 PTAL - I couldn't see any race conditions that would cause the failures we were seeing in your PR, but I dug into the issue, and this is where I landed. Lemme know if I missed anything though!