Thanks to visit codestin.com
Credit goes to github.com

Skip to content

example: crd-client extra cleanup#4581

Merged
lacroixthomas merged 2 commits into
agones-dev:mainfrom
markmandel:examples/crd-cleanup
May 28, 2026
Merged

example: crd-client extra cleanup#4581
lacroixthomas merged 2 commits into
agones-dev:mainfrom
markmandel:examples/crd-cleanup

Conversation

@markmandel

@markmandel markmandel commented May 22, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Needed an extra go mod tidy.
Also fixed a Dockerfile warning.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

Pottering on some low level dependabot cleanup 😄

@markmandel markmandel requested a review from a team May 22, 2026 21:18
@markmandel markmandel added the area/examples Examples. Usually found in the `examples` directory label May 22, 2026
@github-actions github-actions Bot added the kind/cleanup Refactoring code, fixing up documentation, etc label May 22, 2026
@markmandel
example: crd-client extra cleanup
f13e8c5 
Needed an extra `go mod tidy`.
Also fixed a Dockerfile warning.

Signed-off-by: Mark Mandel <[email protected]>
@markmandel markmandel force-pushed the examples/crd-cleanup branch from b55e1ef to f13e8c5 Compare May 22, 2026 21:19
@agones-bot

agones-bot commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 75012fa0-bb2f-456f-b01f-17f2b927d827

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel

markmandel commented May 22, 2026

Copy link
Copy Markdown
Member Author

/gcbrun

VERBOSE: I0522 21:52:40.939445   10594 request.go:752] "Waited before sending request" delay="1.297508885s" reason="client-side throttling, not priority and fairness" verb="POST" URL="https://34.53.208.232/apis/allocation.agones.dev/v1/namespaces/1779486711/gameserverallocations"
VERBOSE: time="2026-05-22 21:52:43.199" level=info msg="Allocation error: an error on the server (\"could not update the selected GameServer\") has prevented the request from succeeding (post gameserverallocations.allocation.agones.dev)" test=TestGameServerAllocationDuringMultipleAllocationClients
VERBOSE: time="2026-05-22 21:52:45.722" level=info msg="Allocation error: an error on the server (\"could not update the selected GameServer\") has prevented the request from succeeding (post gameserverallocations.allocation.agones.dev)" test=TestGameServerAllocationDuringMultipleAllocationClients
VERBOSE: time="2026-05-22 21:52:47.706" level=info msg="Finished allocation attempts" test=TestGameServerAllocationDuringMultipleAllocationClients
VERBOSE:     gameserverallocation_test.go:1479: Test failed: Less than 98 GameServers were allocated. Allocated: 97
VERBOSE: --- FAIL: TestGameServerAllocationDuringMultipleAllocationClients (55.78s)

Doesn't happen often, but does still happen from time to time.

@agones-bot

agones-bot commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 0c0f5cd7-66ea-4f4c-ba17-ae8300c2cc2e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4581/head:pr_4581 && git checkout pr_4581
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.59.0-dev-f13e8c5

@lacroixthomas lacroixthomas enabled auto-merge (squash) May 28, 2026 21:59
@agones-bot

agones-bot commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 06e8afe2-b503-4726-bd1c-4e49d52b77ba

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4581/head:pr_4581 && git checkout pr_4581
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.59.0-dev-d264238

@lacroixthomas lacroixthomas merged commit 8554a5e into agones-dev:main May 28, 2026
4 checks passed
@markmandel markmandel deleted the examples/crd-cleanup branch May 31, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lacroixthomas lacroixthomas lacroixthomas approved these changes

Assignees

No one assigned

Labels

area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markmandel @agones-bot @lacroixthomas