Remove PlayerTracking documentation references#4585
Conversation
|
Build Failed 😭 Build Id: a4554fac-73d8-4931-9724-ce384188f4d7 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
/gcbrun |
|
Build Succeeded 🥳 Build Id: 79b419b5-1f23-41e1-9cfe-cf3801a1c33a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Hope you don't mind - I edited the PR to be "works on" rather than "closes" - since this is just the first step. |
markmandel
left a comment
There was a problem hiding this comment.
Good start! But if we're going to remove the docs, we should do all of it.
I noticed the following still had references to player tracking:
- https://cf74e98-dot-preview-dot-agones-images.appspot.com/site/docs/guides/client-sdks/cpp/
- https://cf74e98-dot-preview-dot-agones-images.appspot.com/site/docs/guides/client-sdks/unity/
- https://cf74e98-dot-preview-dot-agones-images.appspot.com/site/docs/guides/client-sdks/unreal/
- https://cf74e98-dot-preview-dot-agones-images.appspot.com/site/docs/guides/client-sdks/go/
- https://cf74e98-dot-preview-dot-agones-images.appspot.com/site/docs/guides/client-sdks/python/
👍🏻
Thanks for the review! I didn't include those files initially since they weren't mentioned in the issue, but I will go ahead and remove the references from them as well and update the PR. |
|
Build Failed 😭 Build Id: 0fbab2be-6e77-4400-9357-c8d250ee7658 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😭 Build Id: 36191d9d-2d73-4191-b620-1a28b99168d7 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 🥳 Build Id: d032ff2e-e73a-4a8e-861c-629e3454df0c The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Succeeded 🥳 Build Id: caa1fd0c-90bd-4a92-8dfd-cb3dce79b4a1 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
markmandel
left a comment
There was a problem hiding this comment.
Exciting! Great to be removing this finally!
* Remove PlayerTracking documentation references * removed player tracking references * removed player tracking --------- Co-authored-by: Sivasankaran R <[email protected]> Signed-off-by: Cloud-Architect-Emma <[email protected]>
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Work on #4491
Special notes for your reviewer: