Codestin Search App

indurireddy-TF · 2026-06-17T15:10:30Z

What type of PR is this?

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Work on #4491

Did you use AI tools in preparing this PR?:
Yes. I used AI tools as a pair-programming assistant to help me understand existing test cases and to provide suggestions for the changes.

Special notes for your reviewer:

agones-bot · 2026-06-17T15:16:48Z

Build Failed 😭

Build Id: 7203e566-ddde-4bf7-a8b2-1edf5a6cc4f7

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-06-17T15:31:20Z

Build Failed 😭

Build Id: a722bbe7-6bae-4eaf-9336-5b7ba3d72faa

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-06-17T15:47:38Z

Build Failed 😭

Build Id: b597e097-b881-42f1-93d6-5c3419cbf57a

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2026-06-18T22:48:29Z

Looks like you need to regen the reference docs.

>>> Error: API docs are out of date. Please run 'make gen-api-docs' to regenerate them since the CRD information in /pkg/apis has changed.

markmandel · 2026-06-18T22:51:10Z

Also noting DCO is missing.

agones-bot · 2026-06-18T23:03:59Z

Build Failed 😭

Build Id: a109ede9-dc5e-4d35-8d92-d71ee214eae5

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-06-19T12:46:19Z

Build Failed 😭

Build Id: d8924aa9-f529-45ef-9fe0-b2ac5b73774c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-06-19T13:45:25Z

Build Succeeded 🥳

Build Id: ba3bc611-6bbe-4f1d-ad19-79d012c6e70a

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.59.0-dev-343c627
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.59.0-dev-343c627
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.59.0-dev-343c627-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.59.0-dev-343c627
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.59.0-dev-343c627
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.59.0-dev-343c627
Linux C++ SDK (build): agonessdk-1.59.0-dev-343c627-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.59.0-dev-343c627.zip

A preview of the website (the last 30 builds are retained):

https://343c627-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4624/head:pr_4624 && git checkout pr_4624
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.59.0-dev-343c627

agones-bot · 2026-06-20T15:42:17Z

Build Succeeded 🥳

Build Id: b780ee0f-4222-456e-b762-9fe769a05cd5

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.59.0-dev-684a5ae
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.59.0-dev-684a5ae
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.59.0-dev-684a5ae-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.59.0-dev-684a5ae
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.59.0-dev-684a5ae
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.59.0-dev-684a5ae
Linux C++ SDK (build): agonessdk-1.59.0-dev-684a5ae-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.59.0-dev-684a5ae.zip

A preview of the website (the last 30 builds are retained):

https://684a5ae-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4624/head:pr_4624 && git checkout pr_4624
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.59.0-dev-684a5ae

markmandel · 2026-06-20T17:15:48Z

Did you use AI tools in preparing this PR?:

Y/N

Before merging - we need disclosure on if you used AI or not. Doesn't matter, but that's the policy.

markmandel · 2026-06-20T17:17:00Z

Also fyi - edited your description to be "Work on #4491" - since this doesn't close the issue. Still more stuff to be done 👍🏻

indurireddy-TF · 2026-06-22T04:47:26Z

Did you use AI tools in preparing this PR?:
Y/N

Before merging - we need disclosure on if you used AI or not. Doesn't matter, but that's the policy.

sure

indurireddy-TF · 2026-06-22T04:55:51Z

Also fyi - edited your description to be "Work on #4491" - since this doesn't close the issue. Still more stuff to be done 👍🏻

I’m going to push the remaining updates into new PRs, which should make them easier for you to review.

markmandel · 2026-06-22T04:55:51Z

😁 is that a yes or a no?

indurireddy-TF · 2026-06-22T04:59:43Z

@markmandel Can we merge these changes so I can pull the latest code and raise the next PR?

markmandel · 2026-06-22T05:11:29Z

Still need to know if you used AI or not. You have neither confirmed nor denied 😄

indurireddy-TF · 2026-06-22T05:16:42Z

😁 is that a yes or a no?

Still need to know if you used AI or not. You have neither confirmed nor denied 😄

Sorry for the confusion with my previous reply To clarify, I manually implemented the changes file by file, using AI only for specific suggestions and to help me understand some of the existing test cases.

markmandel

Looks good - one small thing to update, and fix the conflict.

Also I assume removing the feature in features.go is last?

github-actions · 2026-06-24T08:32:47Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

indurireddy-TF · 2026-06-24T08:41:56Z

Looks good - one small thing to update, and fix the conflict.

Also I assume removing the feature in features.go is last?

The following items remain to be addressed:
Feature Gates
GameServer API + CRD
SDK Alpha APIs
sdkserver + metrics

agones-bot · 2026-06-24T09:34:46Z

Build Failed 😭

Build Id: 900295f3-be75-46eb-90b0-d452795bd8f2

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

indurireddy-TF · 2026-06-24T13:59:54Z

/gcbrun

agones-bot · 2026-06-24T14:53:17Z

Build Succeeded 🥳

Build Id: 71b6ae1b-3fb8-4a23-a1b1-cdac2af8cf11

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.59.0-dev-2c58b5e
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.59.0-dev-2c58b5e
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.59.0-dev-2c58b5e-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.59.0-dev-2c58b5e
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.59.0-dev-2c58b5e
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.59.0-dev-2c58b5e
Linux C++ SDK (build): agonessdk-1.59.0-dev-2c58b5e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.59.0-dev-2c58b5e.zip

A preview of the website (the last 30 builds are retained):

https://2c58b5e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4624/head:pr_4624 && git checkout pr_4624
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.59.0-dev-2c58b5e

github-actions Bot added kind/cleanup Refactoring code, fixing up documentation, etc size/L labels Jun 17, 2026

markmandel reviewed Jun 18, 2026

View reviewed changes

Comment thread examples/gameserver.yaml Outdated

indurireddy-TF force-pushed the remove-player-allocation-filter-api-proto branch from af3671c to 343c627 Compare June 19, 2026 12:48

indurireddy-TF self-assigned this Jun 22, 2026

markmandel reviewed Jun 22, 2026

View reviewed changes

Comment thread proto/allocation/allocation.proto

indurireddy-TF added 4 commits June 24, 2026 08:22

Remove PlayerAllocationFilter from GameServerAllocation API

2a83ff3

sdkprotofiles

24cd37e

generate-docs

0f6cca2

added reserved field

2c58b5e

indurireddy-TF force-pushed the remove-player-allocation-filter-api-proto branch from 684a5ae to 2c58b5e Compare June 24, 2026 08:32

github-actions Bot added the size/XL label Jun 24, 2026

markmandel approved these changes Jun 24, 2026

View reviewed changes

markmandel added the kind/breaking Breaking change label Jun 24, 2026

markmandel merged commit 4370fd8 into main Jun 24, 2026
9 checks passed

markmandel deleted the remove-player-allocation-filter-api-proto branch June 24, 2026 16:16

Uh oh!

Conversation

indurireddy-TF commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agones-bot commented Jun 17, 2026

Uh oh!

agones-bot commented Jun 17, 2026

Uh oh!

agones-bot commented Jun 17, 2026

Uh oh!

markmandel commented Jun 18, 2026

Uh oh!

Uh oh!

markmandel commented Jun 18, 2026

Uh oh!

agones-bot commented Jun 18, 2026

Uh oh!

agones-bot commented Jun 19, 2026

Uh oh!

agones-bot commented Jun 19, 2026

Uh oh!

agones-bot commented Jun 20, 2026

Uh oh!

markmandel commented Jun 20, 2026

Uh oh!

markmandel commented Jun 20, 2026

Uh oh!

indurireddy-TF commented Jun 22, 2026

Uh oh!

indurireddy-TF commented Jun 22, 2026

Uh oh!

markmandel commented Jun 22, 2026

Uh oh!

indurireddy-TF commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

markmandel commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

indurireddy-TF commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

markmandel left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 24, 2026

Uh oh!

indurireddy-TF commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agones-bot commented Jun 24, 2026

Uh oh!

indurireddy-TF commented Jun 24, 2026

Uh oh!

agones-bot commented Jun 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

indurireddy-TF commented Jun 17, 2026 •

edited

Loading

indurireddy-TF commented Jun 22, 2026 •

edited

Loading

markmandel commented Jun 22, 2026 •

edited

Loading

indurireddy-TF commented Jun 22, 2026 •

edited

Loading

markmandel left a comment •

edited

Loading

indurireddy-TF commented Jun 24, 2026 •

edited

Loading