Icon support for SettingButton and SettingPicker and trailing label support for SettingPage #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wThis commit adds an optional `icon` property to `SettingButton` and `SettingPagePreviewView` structs, allowing for the display of an icon alongside the title in these settings components
Contributor
Author
|
This PR would cover #12 |
Owner
|
Thanks for the PR - sorry for getting back to you so late. Checking this out... |
Owner
|
Thanks! |
Owner
|
Resolved the merge conflict here: 4f9c736 |
Owner
|
Added an example:
SettingPage(title: "Extras", selectedChoice: "Hello, world!") {
SettingGroup {
SettingButton(title: "Hello, world!") {
print("Hello world pressed!")
}
.icon(icon: .system(icon: "ellipsis", backgroundColor: Color.teal))
}
SettingGroup {
SettingButton(title: ":)") {
print(":) pressed!")
}
.icon(icon: .system(icon: "sparkles", backgroundColor: Color.pink))
.indicator("face.smiling")
}
}
.previewIcon(icon: .system(icon: "ellipsis", backgroundColor: Color.teal)) |
This was referenced Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for creating an awesome library!
This PR implements icon support for SettingButton and SettingPicker, as well as trailing label support for SettingPage, to ensure consistency with the look and feel of iOS Settings.