Added some tests in test_learning.py #293
Conversation
tests/test_learning.py
Outdated
| @@ -12,3 +12,31 @@ def test_weighted_mode(): | |||
|
|
|||
| def test_weighted_replicate(): | |||
| assert weighted_replicate('ABC', [1, 2, 1], 4) == ['A', 'B', 'B', 'C'] | |||
|
|
|||
There was a problem hiding this comment.
I really appreciate your work. There is just a small mistake.
You are required to import rms_error(), manhattan_distance(), mean_boolean_error() and mean_error() from learning.
|
Now there is a conflict in learning.py |
|
Actually I have already resolved the issue #295 in this pull request in addition to adding the tests. I referenced that commit in the issue too. |
|
I didn't know you resolved the issue #295 in your pull request. I independently resolved it. Sorry for any inconvenience caused. |
01700a5 to
6368474
Compare
|
@TheSPARTA Could you break this PR into 2 parts, 1 which resolves the mistake in count() and one which adds test cases after resolving the conflicts. You can aslo uncomment the mean_boolean_error() test cases as the bug seems to be fixed |
Added tests for the
errorfunctions inlearning.pyas required by #286 .@reachtarunhere, What kind of other tests can be added?