-
Notifications
You must be signed in to change notification settings - Fork 3.9k
added examples to notebooks LOGIC & PLANNING #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added examples to planning.ipynb: PDLL Actions Air_cargo_problem spare_tire_problem blocks_world
added examples to logic.ipynb: PropKB tt_entail tt_check_all dpll_satisfiable WalkSAT SATplan unify
I will paste some of my feedback from my previous comment so that it doesn't get lost.
Like before, the notebooks you provided are lacking in description. While you did improve this since last time, there is still a lot missing. The majority of the examples you provide are not adequately explained and leave a lot up to the reader. I'm not saying explain every little detail, but you need to write a bit more. As an example take the following: KB.tell(A & C) KB.ask(A) == KB.ask(C) == {} You write the above code and the explanation you write is this: "adds sentence and checks if KB entails the query." This brings up a lot of questions: Is "A & C" the sentence? What does "KB.ask(A)" do? Why does it return an empty dictionary? What exactly is "A"? All these questions can be easily answered by a couple of sentences. This is definitely an improvement from last time and you are on the right track, but in my opinion this still needs work before it gets merged. Again, this is ultimately up to @norvig, but I would take quality and thoroughness over quantity. |
added factored state representation, assumptions, dock worker robot domain.
I like these additions. Very nice work. Did you make the images yourself? |
@MrDupin Thank you, your feedback helped out. |
That depends, but maybe not. If you share where you found them I can look into this more. |
@sofmonk That depends. In most cases you are not allowed to reuse the images without permission. It would be better if we used images in the textbook or make them on our own. |
"| Inequality (Xor) | P ≠ Q | `P ^ Q` | `P ^ Q` | `Expr('^', P, Q)`\n", | ||
"| Implication | P → Q | `P` <tt>|</tt>`'==>'`<tt>|</tt> `Q` | `P ==> Q` | `Expr('==>', P, Q)`\n", | ||
"| Reverse Implication | Q ← P | `Q` <tt>|</tt>`'<=='`<tt>|</tt> `P` |`Q <== P` | `Expr('<==', Q, P)`\n", | ||
"| Equivalence | P ↔ Q | `P` <tt>|</tt>`'<=>'`<tt>|</tt> `Q` |`P <=> Q` | `Expr('<=>', P, Q)`\n", | ||
"| Equivalence | P ↔ Q | `P` <tt>|</tt>`'<=>'`<tt>|</tt> `Q` |`P ==> Q` | `Expr('==>', P, Q)`\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, I appreciate the work on this! But we need to resolve some issues -- the branch has conflicts, the rights to the photos have to be figured out (we need to get permission to the author (or the author has to state a license agreement like creative commons) and we have to give credit to the original author. And there are a few comments from MrDupin should be addressed. |
Sir, I found some examples/diagrams from the other websites good, but I didn't include them as I was skeptical if we can add content from other websites. Please let me know so that I can add them?