Implemented GA in notebook search.ipynb #488
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
converted method sample(self) to propety and removed the call in the statement return self.sampler
minor code formatting.
Implemented Genetic Algoritm in search.py and search.ipynb
Implmented GA
…ording to flake8. Demonstrated the working of GA iin search.ipynb.
…ording to flake8. Demonstrated the working of GA iin search.ipynb.
Removed the image links and included the images used in the image folder. Reduced the file size from 2.4 MB to 183 KB. For every 21 print statements that we previously had, now we have 2, only printing the fittest individual in each generation. The instructions has been made to get the detailed output.
|
@Agent-Pandit You might have to add .idea in your gitignore or not add it to your commit. There are a few xml files which I think are created by your IDE. It also has new line as '\r\n' instead of '\n' as mentioned in #417 |
|
@Chipe1 thanks for pointing it out. Do I need to make another PR or this will work? |
|
I'm not sure how to uncommit changes. Maybe you can delete the files in a new commit and also fix the merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the image links and included the images used in the image folder. Reduced the file size from 2.4 MB to 183 KB. For every 21 print statements that we previously had, now we have 2, only printing the fittest individual in each generation. The instructions has been made to get the detailed output.