Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix build #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix build #500

wants to merge 2 commits into from

Conversation

lucasmoura
Copy link
Contributor

The build is currently broken, that's because the fuzzywuzzy lib was not being installed during the build.

Also, there was a error message with a local path in the search notebook, which I think is a bad idea. Therefore, I removed it.

@antmarakis
Copy link
Collaborator

I agree with @Chipe1 on #497 that it would be better if we did not use the fuzzywuzzy library just for this one function, so I don't think we should be adding it to the requirements.

@lucasmoura
Copy link
Contributor Author

@MrDupin Yes, I agree adding the new lib is not a good idea. However, until we fix that properly, I don't think the build should stay broken. That's the only reason for this MR.

@antmarakis
Copy link
Collaborator

Yes, definitely.

@Chipe1
Copy link
Contributor

Chipe1 commented Apr 15, 2017

@lucasmoura #501 would fix the dependency issue. As for the error with the local path, there are 4 more in search.ipynb
Would be nice if you removed those errors too.

@antmarakis
Copy link
Collaborator

I fixed the other notebook errors in another PR, #503.

@lucasmoura
Copy link
Contributor Author

Seems this MR is not necessary anymore.

@lucasmoura lucasmoura closed this Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants