Implementation: Current Best Learning #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing and reopening (to restart the build) because an unrelated test failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the pseudocode from chapter 19, and added testcases.
Since the
learningmodule is getting a bit too large, I decided to create a new module (knowledgefor the chapter title "Knowledge in Learning"). I feel like this is the best way to go, but I can change it if this is not appropriate.PS: This is an updated #591. Now performance is better + I settled on the format of the hypothesis (list of dictionaries, each dictionary represents a disjunction). I have worked on some other algorithms from the chapter, and this is the most appropriate format.