FOIL #625
Merged
FOIL #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norvig
reviewed
Aug 24, 2017
| @@ -231,6 +234,117 @@ def consistent_det(A, E): | |||
| # ______________________________________________________________________________ | |||
|
|
|||
|
|
|||
| class FOIL_container(FolKB): | |||
There was a problem hiding this comment.
I think this should be called FOILKB.
norvig
reviewed
Aug 24, 2017
| else: | ||
| return list(set(symbol for arg in x.args for symbol in prop_symbols(arg))) | ||
| return {symbol for arg in x.args for symbol in prop_symbols(arg)} |
There was a problem hiding this comment.
OK, or could be
return set().union(map(prop_symbols, x.args))
norvig
reviewed
Aug 24, 2017
| else: | ||
| return list({symbol for arg in x.args for symbol in constant_symbols(arg)}) | ||
| return {symbol for arg in x.args for symbol in constant_symbols(arg)} |
There was a problem hiding this comment.
Similar here as for prop_symbols
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a basic implementation of FOIL.
The original algo, being intended for use in Prolog, is not directly compatible with python. So I've used FolKB to store and process the knowledge. This works for easy examples like the network given in the original paper and the family tree example.
The removing of positive examples is not recursive, and this is leading to technically correct but long and overfitted clauses. Any help in fixing that would be appreciated.