Added simpleProblemSolvingAgent in search.ipynb #791
Conversation
There was a problem hiding this comment.
Overall, it's a nice addition but needs a bit of a clean up. First of all, the image name has a typo: It is 'problem' instead of 'probem' + I would prefer if 'JPG' was not capitalized.
Also, I noticed some small typos here and there, while the image was also not rendering (you should use Markdown code as I write in the comment below).
Finally, you have not installed networkx and when you ran one of the scripts an error was thrown. You need to clean this up.
search.ipynb
Outdated
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "Let us now define a Simple Problem Solving Agent Program. We will create a simpleAgent class which will inherit from the abstract class `SimpleProblemSolvingAgentProgram` and overides it methods. We will create a simple intelligent vacuum agent which can be in any one of the following states. It will move to any other state depending upon the current state as shown in the picture by arrows:\n", |
There was a problem hiding this comment.
I am not sure what 'simpleAgent' is. If it is two words, you should add a space between them. If it is a var/class name, you should put ` around it.
'Overide' has two 'r's. Also, you write 'overide it methods', while it should be 'its' instead of 'it'.
search.ipynb
Outdated
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "Now, we will define all the 8 states and create an object of the above class. Then, we will pass it different states and check the output" |
There was a problem hiding this comment.
Add a colon ( : ) at the end of the sentence.
search.ipynb
Outdated
| "outputs": [ | ||
| { | ||
| "ename": "ModuleNotFoundError", | ||
| "evalue": "No module named 'networkx'", |
There was a problem hiding this comment.
It seems you have not installed the networkx library, and thus you introduced an error here. Install the library and rerun the cell.
search.ipynb
Outdated
| "metadata": {}, | ||
| "source": [ | ||
| "Let us now define a Simple Problem Solving Agent Program. We will create a simpleAgent class which will inherit from the abstract class `SimpleProblemSolvingAgentProgram` and overides it methods. We will create a simple intelligent vacuum agent which can be in any one of the following states. It will move to any other state depending upon the current state as shown in the picture by arrows:\n", | ||
| "<img src=\"files/images/simple_probem_solving_agent.jpg\">" |
There was a problem hiding this comment.
Use Markdown to show the image instead of the html tag.
 should do the trick. (Don't forget to fix the image name!)
There was a problem hiding this comment.
I changed it but wanted to know why is it better to use markdown and not html tag? because I say in some other file the html tag? @MrDupin
|
Done with the changes you requested. Please review @MrDupin |
|
There are merge conflicts, presumably because #787 also replaces the %psource magic with the psource function. It would be easier if you open a new PR after you update your working directory. |
|
You don't really have to open a new PR. This is what I do in similar situations:
If the differences between the current notebook at the PR notebook aren't that big, there is not going to be an issue. |
There was only the explanation of simpleProblemSolvingAgentProgram in the search.ipynb. I included a program on that. @MrDupin Can you please review?