Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added simpleProblemSolvingAgent in search.ipynb #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

nouman-10
Copy link
Contributor

There was only the explanation of simpleProblemSolvingAgentProgram in the search.ipynb. I included a program on that. @MrDupin Can you please review?

Copy link
Collaborator

@antmarakis antmarakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it's a nice addition but needs a bit of a clean up. First of all, the image name has a typo: It is 'problem' instead of 'probem' + I would prefer if 'JPG' was not capitalized.

Also, I noticed some small typos here and there, while the image was also not rendering (you should use Markdown code as I write in the comment below).

Finally, you have not installed networkx and when you ran one of the scripts an error was thrown. You need to clean this up.

search.ipynb Outdated
"cell_type": "markdown",
"metadata": {},
"source": [
"Let us now define a Simple Problem Solving Agent Program. We will create a simpleAgent class which will inherit from the abstract class `SimpleProblemSolvingAgentProgram` and overides it methods. We will create a simple intelligent vacuum agent which can be in any one of the following states. It will move to any other state depending upon the current state as shown in the picture by arrows:\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what 'simpleAgent' is. If it is two words, you should add a space between them. If it is a var/class name, you should put ` around it.

'Overide' has two 'r's. Also, you write 'overide it methods', while it should be 'its' instead of 'it'.

search.ipynb Outdated
"cell_type": "markdown",
"metadata": {},
"source": [
"Now, we will define all the 8 states and create an object of the above class. Then, we will pass it different states and check the output"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a colon ( : ) at the end of the sentence.

search.ipynb Outdated
"outputs": [
{
"ename": "ModuleNotFoundError",
"evalue": "No module named 'networkx'",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you have not installed the networkx library, and thus you introduced an error here. Install the library and rerun the cell.

search.ipynb Outdated
"metadata": {},
"source": [
"Let us now define a Simple Problem Solving Agent Program. We will create a simpleAgent class which will inherit from the abstract class `SimpleProblemSolvingAgentProgram` and overides it methods. We will create a simple intelligent vacuum agent which can be in any one of the following states. It will move to any other state depending upon the current state as shown in the picture by arrows:\n",
"<img src=\"files/images/simple_probem_solving_agent.jpg\">"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Markdown to show the image instead of the html tag.

![simple problem solving agent](images/simple_problem_solving_agent.jpg) should do the trick. (Don't forget to fix the image name!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it but wanted to know why is it better to use markdown and not html tag? because I say in some other file the html tag? @MrDupin

@nouman-10
Copy link
Contributor Author

nouman-10 commented Mar 3, 2018

Done with the changes you requested. Please review @MrDupin

@ad71
Copy link
Contributor

ad71 commented Mar 3, 2018

There are merge conflicts, presumably because #787 also replaces the %psource magic with the psource function. It would be easier if you open a new PR after you update your working directory.

@antmarakis
Copy link
Collaborator

You don't really have to open a new PR. This is what I do in similar situations:

  1. I copy the current notebook as found in the repo.
  2. I copy-paste the changes I made in my notebook to the other one.
  3. Copy paste the merged notebook to the PR, click the "Resolved Conflicts" button.

If the differences between the current notebook at the PR notebook aren't that big, there is not going to be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants