Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed planning notebook #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed planning notebook #944

wants to merge 1 commit into from

Conversation

ad71
Copy link
Contributor

@ad71 ad71 commented Aug 3, 2018

I wrote notebook sections for GraphPlan, TotalOrderPlanner, PartialOrderPlanner, double_tennis_problem and job_shop_problem in PR #927 .
But the whole notebook was reverted back to an older version by #943 and replaced by a lot of other notebooks containing parts of the original notebook. This, I think was completely unnecessary as we are trying to maintain one notebook per chapter and moreover, a lot of the work I did on the planning notebook was removed and overwritten. This happened because the author of #943 used an outdated fork of the repository.
Here is a new PR that fixes these problems and also incorporates the notebook sections for angelic_search and hierarchical_search.

@delaray
Copy link
Contributor

delaray commented Aug 8, 2018

@ad71 : Actually @norvig has decided to have a seaparate notebook for each algorithm of each chapter. We started implementing that model this summer.

@delaray
Copy link
Contributor

delaray commented Aug 8, 2018

@ad71 : To my best of knowledge no code was overwritten, only extended and fixed in certain places. The author of #973 is using the most recent version of master for each branch that she creates. However there were at the time a number of PR's that haven't been merged yet and naturally these will not be present in her master fork.

@ad71
Copy link
Contributor Author

ad71 commented Aug 8, 2018

@delaray I had no idea that Dr. Norvig had decided to separate the notebooks. In that case, everything seems fine. I'll close this PR after I check the diffs once again. Thanks!

@delaray
Copy link
Contributor

delaray commented Aug 8, 2018

@ad71 : Sounds good. Thanks.

@ad71 ad71 closed this Aug 27, 2018
@ad71 ad71 deleted the planning branch September 1, 2018 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants