Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: remove stale response_factory param from add_static docs#12797

Merged
Dreamsorcerer merged 3 commits into
aio-libs:masterfrom
wahajahmed010:fix/12718-remove-stale-response-factory-from-docs
Jun 8, 2026
Merged

docs: remove stale response_factory param from add_static docs#12797
Dreamsorcerer merged 3 commits into
aio-libs:masterfrom
wahajahmed010:fix/12718-remove-stale-response-factory-from-docs

Conversation

@wahajahmed010

Copy link
Copy Markdown
Contributor

Closes #12718

Approach

The response_factory parameter was removed from the add_static implementation in PR #2290, but the method signature shown in the documentation (docs/web_reference.rst) still listed it. This fix removes the stale response_factory=StreamResponse line from the documented signature, matching the actual API.

Changes

  • docs/web_reference.rst: Removed response_factory=StreamResponse line from the .. method:: add_static(...) signature
  • CHANGES/12718.doc.rst: Added changelog entry (one file, one line deleted)

AI assistance disclosure: This fix was created with assistance from an AI coding assistant (Claude/Buck). The human author reviewed and validated all changes.

Closes aio-libs#12718

The response_factory parameter was removed from the add_static
implementation in PR aio-libs#2290. This fix removes it from the method
signature shown in the documentation to match the actual API.

AI assistance disclosure: This fix was created with assistance from
an AI coding assistant (Claude/Buck). The human author reviewed and
validated all changes.
@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label Jun 3, 2026
@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.95%. Comparing base (7f0532c) to head (a78ad3b).
⚠️ Report is 303 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12797      +/-   ##
==========================================
- Coverage   98.95%   98.95%   -0.01%     
==========================================
  Files         131      131              
  Lines       46688    47719    +1031     
  Branches     2421     2475      +54     
==========================================
+ Hits        46200    47219    +1019     
- Misses        366      376      +10     
- Partials      122      124       +2     
Flag Coverage Δ
Autobahn 22.26% <ø> (-0.16%) ⬇️
CI-GHA 98.92% <ø> (-0.01%) ⬇️
OS-Linux 98.68% <ø> (-0.01%) ⬇️
OS-Windows 97.07% <ø> (+0.03%) ⬆️
OS-macOS 97.94% <ø> (+0.01%) ⬆️
Py-3.10 98.17% <ø> (+0.01%) ⬆️
Py-3.11 98.42% <ø> (+<0.01%) ⬆️
Py-3.12 98.50% <ø> (+<0.01%) ⬆️
Py-3.13 98.48% <ø> (+<0.01%) ⬆️
Py-3.14 98.50% <ø> (+<0.01%) ⬆️
Py-3.14t 97.58% <ø> (+0.02%) ⬆️
Py-pypy-3.11 97.45% <ø> (+<0.01%) ⬆️
VM-macos 97.94% <ø> (+0.01%) ⬆️
VM-ubuntu 98.68% <ø> (-0.01%) ⬇️
VM-windows 97.07% <ø> (+0.03%) ⬆️
cython-coverage 38.14% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codspeed-hq

codspeed-hq Bot commented Jun 3, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 72 skipped benchmarks1


Comparing wahajahmed010:fix/12718-remove-stale-response-factory-from-docs (a78ad3b) with master (d559f11)

Open in CodSpeed

Footnotes

  1. 72 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot backport-3.15 Trigger automatic backporting to the 3.15 release branch by Patchback robot labels Jun 8, 2026
@Dreamsorcerer Dreamsorcerer merged commit 86c33ba into aio-libs:master Jun 8, 2026
87 of 90 checks passed
@patchback

patchback Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Backport to 3.14: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.14/86c33baaa748bcb240a085e2d2e89cf2055a160a/pr-12797

Backported as #12867

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback

patchback Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Backport to 3.15: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.15/86c33baaa748bcb240a085e2d2e89cf2055a160a/pr-12797

Backported as #12868

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Dreamsorcerer pushed a commit that referenced this pull request Jun 8, 2026
…ry param from add_static docs (#12868)

**This is a backport of PR #12797 as merged into master
(86c33ba).**

Co-authored-by: Wahaj Ahmed <[email protected]>
Dreamsorcerer pushed a commit that referenced this pull request Jun 8, 2026
…ry param from add_static docs (#12867)

**This is a backport of PR #12797 as merged into master
(86c33ba).**

Co-authored-by: Wahaj Ahmed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot backport-3.15 Trigger automatic backporting to the 3.15 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

response_factory is documented, but not present

2 participants