Conversation
| if (AccountEvent.Type.UNLOCKED.equals(event.getType())) { | ||
| this.account = event.getAccount(); | ||
| this.account = event.getPayload(); | ||
| // unlockPassword.requestFocus(); |
Contributor
There was a problem hiding this comment.
remove comment
centrys-victor
approved these changes
Jun 15, 2018
| final String address = addressIterator.next(); | ||
| final BlockDTO lastSafeBlock = getAccountManager().getLastSafeBlock(address); | ||
| if (lastSafeBlock != null) { | ||
| if (oldestSafeBlock == null) { |
Contributor
There was a problem hiding this comment.
can be refactored into oldestSafeBlock == null || oldestSafeBlock.getNumber() > lastSafeBlock.getNumber()
| @Override | ||
| public void initialize(final URL location, final ResourceBundle resources) { | ||
| registerEventBusConsumer(); | ||
| Platform.runLater(() -> unlockPassword.requestFocus()); |
Contributor
There was a problem hiding this comment.
Thanks for this one
Contributor
Author
There was a problem hiding this comment.
This is my single most satisfying feature
| private static final String AION_LOGO = "components/icons/aion-icon.png"; | ||
|
|
||
| private final BlockchainConnector blockchainConnector = BlockchainConnector.getInstance(); | ||
| private static final String LOCAL_DIR = System.getProperty("user.dir"); |
Contributor
There was a problem hiding this comment.
Couldn't this be local.storage.dir ?
Contributor
Author
There was a problem hiding this comment.
actually no, beacuse this is where the app is started from, so we need this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.