Added filtering in the history table#94
Merged
Merged
Conversation
5b26de1 to
49d6553
Compare
theotniel
reviewed
Jun 14, 2018
| private void initSearchItemDropdown() { | ||
| searchItem.setItems(FXCollections.observableArrayList( | ||
| "Type", | ||
| "Date", |
| completeTransactionList = new ArrayList<>(transactions); | ||
| txTable.setItems(FXCollections.observableList(transactions)); | ||
| }, | ||
| getEmptyEvent(), null |
Contributor
There was a problem hiding this comment.
why null? this will throw NPE if task is cancelled, no?
| event -> txTable.setItems(FXCollections.observableList(getTransactionsTask.getValue())), | ||
| getErrorEvent(t -> {}, getTransactionsTask), | ||
| getEmptyEvent() | ||
| event -> { |
Contributor
There was a problem hiding this comment.
it would be nice to have a method that returns an event here
| }); | ||
| } | ||
|
|
||
| private boolean anyFieldHasString(TxRow s, String newValue) { |
Contributor
There was a problem hiding this comment.
final params?
since you're matching strings only with selected searchItem maybe this could have a better name
| txTable.setContextMenu(menu); | ||
|
|
||
|
|
||
| searchField.textProperty().addListener((observable, oldValue, newValue) -> { |
Contributor
There was a problem hiding this comment.
we should add this listener to the drop-down field as well, albeit it will probably have a different filtering predicate
|
|
||
|
|
||
| searchField.textProperty().addListener((observable, oldValue, newValue) -> { | ||
| FilteredList<TxRow> filteredData = new FilteredList(FXCollections.observableList(completeTransactionList), s -> true); |
Contributor
There was a problem hiding this comment.
this row can be final FilteredList<TxRow> filteredData = new FilteredList<> (FXCollections.observableList(completeTransactionList));
since you add the filer predicate in the conditional block below anyway
theotniel
approved these changes
Jun 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.