Expose MagazineLayout.Default enum as public (#10) #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryankeller
requested changes
Jan 10, 2019
Contributor
bryankeller
left a comment
There was a problem hiding this comment.
Thanks for putting a PR up @diegorozen! This makes sense to me - my only change request is for MagazineLayout+Default.swift to be moved from MagazineLayout/LayoutCore/Types/ to MagazineLayout/Public/Types/.
Thanks for bumping the pod version as well!
bryankeller
reviewed
Jan 10, 2019
bryankeller
approved these changes
Jan 10, 2019
Contributor
bryankeller
left a comment
There was a problem hiding this comment.
Thanks for making those changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
While I was building an RxSwift extension for MagazineLayout (which can be discussed in a different topic), I needed to provide sensible defaults for the cases when a forwarding delegate was not defined. Those defaults have already being defined by the lib in MagazineLayout.Default, but they are not visible outside the library.
Since that enum doesn't expose any internal implementation details, it would be helpful to mark it as public
Related Issue
Fixes #10
Motivation and Context
How Has This Been Tested
N/A
Types of changes
Checklist