Codestin Search App

Aaron ("AJ") Steers (aaronsteers) · 2026-02-06T17:39:25Z

Summary

Moves the create_connector_test_suite import in _connector.py from module-level to inside run_connector_tests(), making it lazy. This fixes uvx airbyte-cdk secrets list ... (and all other CLI commands) failing with ModuleNotFoundError: No module named 'pytest' when the [dev] extra is not installed.

Root cause: __init__.py eagerly imports _connector.py, which eagerly imports create_connector_test_suite from test.standard_tests.util, which transitively imports docker_base.py, which does a hard import pytest. This breaks the entire CLI—not just connector test—when pytest isn't installed.

The import is placed after the existing pytest is None guard, so users still get a clean error if they run connector test without pytest.

Review & Testing Checklist for Human

Verify uvx airbyte-cdk secrets list <connector> works without [dev] (can test locally: pip install airbyte-cdk in a clean venv, then run airbyte-cdk secrets list source-postgres)
Verify airbyte-cdk connector test still works when pytest IS installed (e.g. in a dev environment with [dev] extra)

Notes

Requested by: Aaron ("AJ") Steers (@aaronsteers)
Link to Devin run

Summary by CodeRabbit

Chores
- Optimized dependency loading to improve performance during test execution.

…v] extra Co-Authored-By: AJ Steers <[email protected]>

devin-ai-integration · 2026-02-06T17:39:31Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

Copilot

Pull request overview

Makes the CLI resilient when optional dev-only test dependencies (e.g., pytest) are not installed by deferring the test-suite import until tests are actually executed.

Changes:

Removes the module-level import of create_connector_test_suite to prevent eager import chains on CLI startup.
Reintroduces the import inside run_connector_tests() after the existing pytest presence guard.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-02-06T17:39:40Z

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1770399442-secrets-without-dev#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1770399442-secrets-without-dev

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

/autofix - Fixes most formatting and linting issues
/poetry-lock - Updates poetry.lock file
/test - Runs connector tests with the updated CDK
/prerelease - Triggers a prerelease publish with default arguments
/poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
/poe <command> - Runs any poe command in the CDK environment

📚 Show Repo Guidance

Helpful Resources

CDK API Reference

📝 Edit this welcome message.

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

airbyte_cdk/cli/airbyte_cdk/_connector.py

Co-Authored-By: AJ Steers <[email protected]>

coderabbitai · 2026-02-06T17:42:06Z

📝 Walkthrough

Walkthrough

The change introduces lazy loading by moving the create_connector_test_suite import from module scope into the run_connector_tests function, deferring dependency resolution until tests are actually executed rather than at module import time.

Changes

Cohort / File(s)	Summary
Lazy Import Refactoring `airbyte_cdk/cli/airbyte_cdk/_connector.py`	Relocated `create_connector_test_suite` import from top-level to function scope within `run_connector_tests`, adding an explanatory comment for the lazy-loading pattern.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: making test imports lazy to allow the secrets command to work without the [dev] extra dependency.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch devin/1770399442-secrets-without-dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

airbyte_cdk/cli/airbyte_cdk/_connector.py

Co-Authored-By: AJ Steers <[email protected]>

github-actions · 2026-02-06T17:50:27Z

PyTest Results (Fast)

3 855 tests ±0 3 843 ✅ ±0 6m 7s ⏱️ -20s
1 suites ±0 12 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit b588ded. ± Comparison against base commit 57c70ba.

github-actions · 2026-02-06T17:55:10Z

PyTest Results (Full)

3 858 tests ±0 3 846 ✅ ±0 10m 52s ⏱️ -14s
1 suites ±0 12 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit b588ded. ± Comparison against base commit 57c70ba.

fix(cli): make test imports lazy so secrets command works without [de…

196146d

…v] extra Co-Authored-By: AJ Steers <[email protected]>

Copilot AI review requested due to automatic review settings February 6, 2026 17:39

devin-ai-integration bot assigned Aaron ("AJ") Steers (aaronsteers) Feb 6, 2026

Copilot AI reviewed Feb 6, 2026

View reviewed changes

devin-ai-integration bot reviewed Feb 6, 2026

View reviewed changes

Aaron ("AJ") Steers (aaronsteers) commented Feb 6, 2026

View reviewed changes

airbyte_cdk/cli/airbyte_cdk/_connector.py Show resolved Hide resolved

chore: add inline comment explaining lazy import

963204a

Co-Authored-By: AJ Steers <[email protected]>

Aaron ("AJ") Steers (aaronsteers) commented Feb 6, 2026

View reviewed changes

airbyte_cdk/cli/airbyte_cdk/_connector.py Outdated Show resolved Hide resolved

chore: move inline comment to line above import

b588ded

Co-Authored-By: AJ Steers <[email protected]>

coderabbitai bot approved these changes Feb 6, 2026

View reviewed changes

Aaron ("AJ") Steers (aaronsteers) merged commit 15fdf5a into main Feb 6, 2026
29 checks passed

Aaron ("AJ") Steers (aaronsteers) deleted the devin/1770399442-secrets-without-dev branch February 6, 2026 18:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cli): make test imports lazy so secrets command works without [dev] extra#900

fix(cli): make test imports lazy so secrets command works without [dev] extra#900
Aaron ("AJ") Steers (aaronsteers) merged 3 commits intomainfrom
devin/1770399442-secrets-without-dev

Aaron ("AJ") Steers (aaronsteers) commented Feb 6, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

devin-ai-integration bot commented Feb 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions bot commented Feb 6, 2026

Testing This CDK Version

PR Slash Commands

Helpful Resources

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

Uh oh!

coderabbitai bot commented Feb 6, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Aaron ("AJ") Steers (aaronsteers) commented Feb 6, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Review & Testing Checklist for Human

Notes

Summary by CodeRabbit

Uh oh!

devin-ai-integration bot commented Feb 6, 2026

🤖 Devin AI Engineer

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions bot commented Feb 6, 2026

👋 Greetings, Airbyte Team Member!

Testing This CDK Version

PR Slash Commands

Helpful Resources

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

Uh oh!

coderabbitai bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2026

PyTest Results (Fast)

Uh oh!

github-actions bot commented Feb 6, 2026

PyTest Results (Full)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Aaron ("AJ") Steers (aaronsteers) commented Feb 6, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 6, 2026 •

edited

Loading