Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: increase MAX_CONNECTION_POOL_SIZE from 20 to 40#926

Draft
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin/1772449759-increase-max-connection-pool-size
Draft

chore: increase MAX_CONNECTION_POOL_SIZE from 20 to 40#926
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin/1772449759-increase-max-connection-pool-size

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Mar 2, 2026

Summary

Increases MAX_CONNECTION_POOL_SIZE from 20 to 40 in airbyte_cdk/sources/http_config.py and updates the two corresponding test assertions.

With connectors now supporting max_concurrency up to 40 (e.g., source-intercom PR), the previous pool size of 20 causes urllib3 warnings:

Connection pool is full, discarding connection: api.intercom.io. Connection pool size: 20

Connections still succeed but bypass the pool (no reuse), reducing efficiency. This change aligns the pool size with the maximum concurrency connectors can configure.

Review & Testing Checklist for Human

  • Verify that 40 concurrent pooled connections per connector instance is acceptable from a memory/socket resource perspective, especially for deployments running many connectors simultaneously
  • Consider whether this constant should instead be made dynamically configurable (tied to the connector's actual max_concurrency setting) rather than a static increase — the existing comment in http_config.py already notes this as a future improvement

Notes

Requested by: gl_anatolii.yatsuk
Devin session

@devin-ai-integration
Copy link
Contributor Author

devin-ai-integration bot commented Mar 2, 2026

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1772449759-increase-max-connection-pool-size#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1772449759-increase-max-connection-pool-size

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /prerelease - Triggers a prerelease publish with default arguments
  • /poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
  • /poe <command> - Runs any poe command in the CDK environment
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

PyTest Results (Fast)

3 869 tests  ±0   3 857 ✅ ±0   6m 26s ⏱️ -25s
    1 suites ±0      12 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 13b692c. ± Comparison against base commit 7f41401.

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

PyTest Results (Full)

3 872 tests   3 860 ✅  11m 26s ⏱️
    1 suites     12 💤
    1 files        0 ❌

Results for commit 13b692c.

@tolik0
Copy link
Contributor

Anatolii Yatsuk (tolik0) commented Mar 2, 2026 •
edited by github-actions bot
Loading

/prerelease

Prerelease Job Info

This job triggers the publish workflow with default arguments to create a prerelease.

Prerelease job started... Check job output.

✅ Prerelease workflow triggered successfully.

View the publish workflow run: https://github.com/airbytehq/airbyte-python-cdk/actions/runs/22575084479

@devin-ai-integration devin-ai-integration bot mentioned this pull request Mar 2, 2026
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tolik0