Fix typo. #6
Open
Fix typo. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. @daxtens I think you wrote this, and I don't think this is a typo but perhaps it could be phrased more clearly? |
|
Thanks.
Yes, this isn't really a typo, just a long and confusing sentence.
Naveen, please could you propose a PR that splits the sentence into shorter
sentences? I think that will be more clear for everyone.
Kind regards,
Daniel
|
|
I've split the sentence into two. |
|
That's fine with me. |
|
I don't know why I'm here but I just noticed that it makes sense to merge. |
PoolloverNathan
suggested changes
Mar 27, 2023
| Then, you keep waiting. Three things may happen: | ||
|
|
||
| * You might get a response to your email. Often these will be comments, which may require you to make changes to your patch, or explain why your way is the best way. You should respond to these comments, and you may need to submit another revision of your patch to address the issues raised. | ||
| * You might get a response to your email. Often these will be comments, which may require you to make changes to your patch. You might be asked to explain why your way is the best. You should respond to these comments, and you may need to submit another revision of your patch to address the issues raised. |
There was a problem hiding this comment.
Suggested change
| * You might get a response to your email. Often these will be comments, which may require you to make changes to your patch. You might be asked to explain why your way is the best. You should respond to these comments, and you may need to submit another revision of your patch to address the issues raised. | |
| * You might get a response to your email. Often these will be comments, which may require you to make changes to your patch. You also might be asked to explain why your way is the best. You should respond to these comments, and you may need to submit another revision of your patch to address the issues raised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.