fix: SBR threshold for down-all-when-indirectly-connected#32875
Merged
Conversation
Contributor
patriknw
commented
Jan 14, 2026
- reproducer of scenario and existing behavior
- add threshold for when all are downed instead of only the detected indirectly connected
- 50% enabled by default
* reproducer of scenario and existing behavior * add threshold for when all are downed instead of only the detected indirectly connected * 50% enabled by default
patriknw
commented
Jan 14, 2026
| import akka.remote.testkit.Direction | ||
| import akka.remote.testkit.MultiNodeConfig | ||
|
|
||
| object DownAllIndirectlyConnected5NodeSpec extends MultiNodeConfig { |
Contributor
Author
There was a problem hiding this comment.
Removed because this was identical to IndirectlyConnected3NodeSpec
johanandren
approved these changes
Jan 14, 2026
Contributor
johanandren
left a comment
There was a problem hiding this comment.
LGTM with one filename correction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.