Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Updated README.rst for later qi versions #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: team/platform/dev
Choose a base branch
from
Open

Updated README.rst for later qi versions #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ following way:
.. code-block:: console

# install/upgrade Conan 2
pip install --upgrade conan~=2
pip install --upgrade conan==2.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous version was wrong indeed (~=2 does not seem to work with pip install), but I think I'd prefer suggesting any Conan version above 2.10:

pip install --upgrade conan~=2.10

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make the update to pull request

# create a default profile
conan profile detect

Expand All @@ -75,7 +75,7 @@ first get and export the `libqi` recipe into your local Conan cache.

# GitHub is available, but you can also use internal GitLab.
QI_REPOSITORY="https://github.com/aldebaran/libqi.git"
QI_VERSION="4.0.1" # Checkout the version your project need.
QI_VERSION="4.0.3" # Checkout the version your project need.
QI_PATH="$HOME/libqi" # Or whatever path you want.
git clone \
--depth=1 `# Only fetch one commit.` \
Expand All @@ -87,7 +87,7 @@ first get and export the `libqi` recipe into your local Conan cache.
# versions of libqi require it
# because of a bug.

You can then install the `libqi-python` dependencies in Conan.
You need to navigate to the ``${HOME}/libqi`` directory and install libqi dependencies.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not exactly correct. The conan install . command below is supposed to be run in the libqi-python directory, and not in libqi. Once the libqi project is exported in Conan (with conan export), the conan install . in libqi-python should build both libqi and its dependencies.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh makes sense.


.. code-block:: console

Expand All @@ -110,6 +110,14 @@ calling:

cmake --list-presets

Navigate back to the ``libqi-python`` directory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're completely right. The instructions below are about building libqi-python native code for development or testing purposes, and not building the wheel. So there should be a section on the same level as the "Wheel" once below.

It's not that much about building "C++ bindings", it's just a different process and purpose.


Now from here you have two options, either to develop the project with only **C++** bindings or
as a **wheel** to run with python

C++ Bindings
------------

Here, we'll assume that the preset is named `conan-linux-x86_64-gcc-debug`.
To start building, you need to configure with CMake and then build:

Expand Down