Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix #67 | provide a way to clear the queries array #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #67 | provide a way to clear the queries array #74

wants to merge 1 commit into from

Conversation

gprasant
Copy link

Tested with the following cases:

dynatable.queries.add('rank', 4);
dynatable.queries.add('country', 'Chile');

dynatable.process();

dynatable.queries.clear();

dynatable.process();

@mlangens
Copy link

Hi @gprasant! I'm helping @JangoSteve with Dynatable. We're getting ready to move forward with a lot of overdue work. We're having a meeting about all open PRs next week. We do require that all contributors sign the CLA. Are you available to do so?

@gprasant
Copy link
Author

whats the CLA ?

@mlangens
Copy link

Our license requires that people contributing release rights to the copyright holder. Here is the link: https://www.clahub.com/agreements/alfajango/jquery-dynatable - Please let me know if you have any more questions!

@gprasant
Copy link
Author

done

—
Sent from Mailbox

On Mon, Oct 26, 2015 at 11:15 AM, Max Langensiepen
[email protected] wrote:

Our license requires that people contributing release rights to the copyright holder. Here is the link: https://www.clahub.com/agreements/alfajango/jquery-dynatable - Please let me know if you have any more questions!

Reply to this email directly or view it on GitHub:
#74 (comment)

@JangoSteve
Copy link
Member

This looks good. While we're at it, I may make it more parallel to the sorts.clear() function here, which also triggers a notification event. Let us know if you'd like to add it, or we can pull this in and then add it.

I'd just remove the comment line at least though.

JangoSteve
JangoSteve reviewed Nov 20, 2015
View reviewed changes
jquery.dynatable.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably can get rid of this comment line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gprasant @mlangens @JangoSteve