Added C++ compilation#939
Merged
Merged
Conversation
ShadowMitia
reviewed
Nov 22, 2021
Member
Author
That's something I want to have, but we need to fix warnings before we can do that. |
leios
approved these changes
Nov 22, 2021
leios
left a comment
Member
There was a problem hiding this comment.
This looks fine to me, happy to approve!
45 tasks
Contributor
That makes sense |
Member
Author
|
Okay, after careful consideration, I think we should have this merged as soon as possible, so we can move on. In short, I'm merging this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the compilation infrastructure for C++.
I had to add the
-std=c++17option because the Barnsley fern code would not compile without it.Apart from that, everything compiles successfully in the right folder on my machine 😃