Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use Scons in CI with container#959

Merged
ntindle merged 38 commits into
mainfrom
use-container-scons
Dec 2, 2021
Merged

Use Scons in CI with container#959
ntindle merged 38 commits into
mainfrom
use-container-scons

Conversation

@ntindle

@ntindle ntindle commented Nov 30, 2021

Copy link
Copy Markdown
Member

No description provided.

@ntindle ntindle changed the title Update build.yml Use Scons in CI with container Nov 30, 2021
@ntindle

ntindle commented Nov 30, 2021

Copy link
Copy Markdown
Member Author

Other than the fact that the container doesn't have cargo it works

Comment thread .github/workflows/build.yml Outdated
@Amaras

Amaras commented Nov 30, 2021

Copy link
Copy Markdown
Member

Alright, let's try and I'll revert if it doesn't run correctly

@Amaras

Amaras commented Nov 30, 2021

Copy link
Copy Markdown
Member

@ntindle here is the full problem:
Neither Cargo nor rustc can be found, leading to the build failure (see build 347 374 I think).

The probable cause is as follows:

  1. When the Rust installer runs, it writes the path manipulation inside $HOME/.bashrc
  2. The GH actions run through sh, which doesn't run the ~/.bashrc file.
  3. Pulling the container, we use bash as a shell.

As such, the solution is to do the path manipulation ourselves in the Dockerfile to ensure consistent paths, even with sh

@ntindle ntindle marked this pull request as ready for review December 2, 2021 06:30
@ntindle

ntindle commented Dec 2, 2021

Copy link
Copy Markdown
Member Author

Okay if whoever merges this doesn't squash and merge, I will cry. THank you for coming to my ted talk

@leios leios left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this looks fine for me; however, I am not sure how to test this properly.

I am happy to merge though, I trust your judgement

@ntindle

ntindle commented Dec 2, 2021

Copy link
Copy Markdown
Member Author

To test, read the details of an action and see if scons passes

@ntindle ntindle merged commit ffaa890 into main Dec 2, 2021
@ntindle ntindle deleted the use-container-scons branch December 2, 2021 19:01
@ntindle ntindle mentioned this pull request Dec 4, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants