chore(code-gen): 1.template sync icejs 2.replace deprecated api #2253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
分开两个PR和commit会不会好点？ |
Contributor
Author
|
嗯，已分开 |
Contributor
|
改了？我看还有 styleImport 插件的引入？ |
Contributor
|
commit msg 也请同步改下~ |
Contributor
Author
|
创建的模版同步 |
Contributor
|
我意思是一个 commit 干一件事情，比如 这样，commit timeline 比较清晰，对于需要 cherry pick 合入其他分支 / revert 回滚某个 commit 也比较方便 当然，PR 里可以罗列多个 commit，commit 是原子数据，PR 是业务/视图数据 |
Contributor
Author
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.