fix: scope props merge defaultProps #2716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 33.63% | 114/339 |
| 🔴 | Branches | 14.53% | 25/172 |
| 🔴 | Functions | 26.14% | 23/88 |
| 🔴 | Lines | 34.23% | 114/333 |
Test suite run success
2 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from 75ff20e
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 80.96% | 370/457 |
| 🟡 | Branches | 76.65% | 279/364 |
| 🟢 | Functions | 88.7% | 102/115 |
| 🟢 | Lines | 81.36% | 358/440 |
Test suite run success
234 tests passing in 40 suites.
Report generated by 🧪jest coverage report action from 75ff20e
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 72.86% (+0.02% 🔼) |
918/1260 |
| 🟡 | Branches | 61.58% | 577/937 |
| 🟡 | Functions | 70% | 196/280 |
| 🟡 | Lines | 72.92% (+0.02% 🔼) |
902/1237 |
Test suite run success
101 tests passing in 8 suites.
Report generated by 🧪jest coverage report action from 75ff20e
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 96.13% | 2853/2968 |
| 🟢 | Branches | 88.65% | 1624/1832 |
| 🟢 | Functions | 95.67% | 862/901 |
| 🟢 | Lines | 96.19% | 2778/2888 |
Test suite run success
384 tests passing in 43 suites.
Report generated by 🧪jest coverage report action from 75ff20e
liujuping
reviewed
Dec 1, 2023
| ...__schema.defaultProps, | ||
| ...this.props, | ||
| }; | ||
| const scope: any = { |
Collaborator
There was a problem hiding this comment.
这里的 this.props 的值不对，包含了很多引擎相关的 props，而非用户需要的 props
Collaborator
Author
There was a problem hiding this comment.
原先的实现就是整个 Renderer 实例当作 scope。可以把这一段注释掉，查看一下原先的 scope.props
Collaborator
There was a problem hiding this comment.
那原来的 props 就不正确，多了很多东西。😓
Collaborator
There was a problem hiding this comment.
要么把原来的 props 问题也解决了，要么再单独记录一个 issue，后面解决。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: scope props merge defaultProps