[WIP] feat: add ACP support - #679
Draft
stay-foolish-forever wants to merge 1 commit into
Draft
Conversation
Contributor
|
✅ OpenCodeReview: No supported files changed. |
DreamZhongJu
added a commit
to DreamZhongJu/open-code-review
that referenced
this pull request
Aug 27, 2026
Implements the "ACP server adapter" direction from PR alibaba#679 / Issue alibaba#674 as a prototype, keeping protocol integration fully decoupled from internal/ as required by the roadmap item. - cmd/ocr-acp/acp: JSON-RPC 2.0 dispatcher over ndjson stdio with ACP v1 subset: initialize (numeric/string version negotiation, explicit empty authMethods), authenticate no-auth reply, session/new with cwd resolution plus available_commands_update (/review, /scan), streamed prompt turns, session/cancel mapping to a cancelled stop reason. - cmd/ocr-acp/wrapper: binary discovery or deterministic mock backend, argv assembly for review/scan (--format json --audience agent), tolerant jsonOutput decoding, strict stdout/stderr separation, bounded stderr tail diagnostics, 5s heartbeats, timeout + cancellation via process-group kill on POSIX and direct kill on Windows. - Tests cover handshake variants, unknown methods and slash commands, the full mock prompt flow (finding chunks -> end_turn), mid-run cancellation, argv rules, tolerant decoding, and pure helper functions. No production code outside cmd/ocr-acp is touched.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Agent Client Protocol (ACP) support to the H2 2026 roadmap.
This draft PR serves as a planning placeholder while the implementation approach is evaluated. The current direction is to expose OpenCodeReview as a specialized review agent for Paseo and other ACP-compatible clients through a decoupled ACP server adapter.
This PR does not implement ACP support yet.
Type of Change
How Has This Been Tested?
Documentation-only change; verified with
git diff --check.make testpasses locallyChecklist
go fmt,go vet)Related Issues
Tracks #674.