feat(format-contributor): added alt attributes
#138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added `alt` attributes to `img` tags which specifies the name of the contributor in them (for accessibility purposes).
I added myself (I forgot to do that) for code (cf. my previous commit), test and doc.
jakebolam
approved these changes
Jan 14, 2019
Collaborator
|
Looks good to me. Thanks @Berkmann18 |
Member
|
🎉 This PR is included in version 5.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Berkmann18
pushed a commit
that referenced
this pull request
May 24, 2020
* docs: correct documentation link to bot usage * test: snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
altattributes toimgtags which specifies the name of thecontributor in them (for accessibility purposes).
What:
imgtags in theformat-contributormodule now have analttag.And I updated the tests accordingly.
Why:
Fix #137 (TL;DR: to improve the accessibility of the generated table)
How:
By code.
Checklist: