This repository was archived by the owner on Dec 16, 2022. It is now read-only.
fix decode in encoder decoder#586
Merged
Merged
Conversation
Contributor
Author
|
@MaxDel This will likely be relevant for you too if you are using the encoder decoder stuff. |
matt-gardner
reviewed
Dec 7, 2017
| predicted_tokens = [self.vocab.get_token_from_index(x, namespace="target_tokens") | ||
| for x in indices] | ||
| all_predicted_tokens.append(predicted_tokens) | ||
| if len(all_predicted_tokens) == 1: |
Contributor
There was a problem hiding this comment.
This is removing the batch dimension, which we don't do here anymore? Is that the issue?
Contributor
Author
There was a problem hiding this comment.
Yep, exactly. Doing this results in the decoded output being the first word if there is a single element in the batch.
Contributor
There was a problem hiding this comment.
Exactly, I also fixed this issue in my local version some time ago.
matt-gardner
approved these changes
Dec 7, 2017
gabrielStanovsky
pushed a commit
to gabrielStanovsky/allennlp
that referenced
this pull request
Sep 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.