Don't send method returns replies when caller doesn't want them #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the actual issue you're running into here? |
|
On some systems AppArmor and DBus spam system log with errors about message delivery failures |
|
Oh ok sounds legitimate. Since the spec says "should not send a reply", I want to keep an override a possibility with manual sending which I think is still possible. Do you want to write a test for it? |
|
Sure, I'll add it to the PR |
Closed
|
👍 |
|
Hey, I wanted to add tests! |
|
Go ahead. I won't release without them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.