fix(codebase): narrow broad except Exception to specific types across…#960
Closed
theonlychant wants to merge 1 commit into
Closed
fix(codebase): narrow broad except Exception to specific types across…#960theonlychant wants to merge 1 commit into
theonlychant wants to merge 1 commit into
Conversation
… codebase Signed-off-by: theonlychant <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Narrows broad
except Exceptioncatches to specific exception typesacross 21 files, making errors surface loudly instead of being swallowed.
Why
CLAUDE.md requires "No Silent Fallbacks - Fail Loudly." Broad exception
catches hide real errors and make debugging harder. Each narrowing targets
the exact exception the code block can raise.
Linked issue
Refs #951
Changes
except (ValueError, json.JSONDecodeError)except ValueErrorexcept OSErrorexcept ImportErrorTest plan
python util/lint.py --all- no failurespytest tests/unit/- all passingChecklist