Remove pycodestyle, add black, add numerous pre-commit checks.#115
Merged
Conversation
|
|
||
| HEREDOC_PATTERN = re.compile(r'<<([a-zA-Z][a-zA-Z0-9._-]+)\n((.|\n)*?)\n\s*\1', re.S) | ||
| HEREDOC_TRIM_PATTERN = re.compile(r'<<-([a-zA-Z][a-zA-Z0-9._-]+)\n((.|\n)*?)\n\s*\1', re.S) | ||
| HEREDOC_PATTERN = re.compile(r"<<([a-zA-Z][a-zA-Z0-9._-]+)\n((.|\n)*?)\n\s*\1", re.S) |
Check failure
Code scanning / CodeQL
Inefficient regular expression
| HEREDOC_TRIM_PATTERN = re.compile(r'<<-([a-zA-Z][a-zA-Z0-9._-]+)\n((.|\n)*?)\n\s*\1', re.S) | ||
| HEREDOC_PATTERN = re.compile(r"<<([a-zA-Z][a-zA-Z0-9._-]+)\n((.|\n)*?)\n\s*\1", re.S) | ||
| HEREDOC_TRIM_PATTERN = re.compile( | ||
| r"<<-([a-zA-Z][a-zA-Z0-9._-]+)\n((.|\n)*?)\n\s*\1", re.S |
Check failure
Code scanning / CodeQL
Inefficient regular expression
rddimon
reviewed
Jan 3, 2023
rddimon
reviewed
Jan 3, 2023
| 2. Create a pull request. Explain why you want to make the change and what it’s for. | ||
|
|
||
| 1. For any sizable change, first open a GitHub issue to discuss your idea. | ||
| 1. Create a pull request. Explain why you want to make the change and what it’s for. |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. Create a pull request. Explain why you want to make the change and what it’s for. | |
| 2. Create a pull request. Explain why you want to make the change and what it’s for. |
Contributor
Author
There was a problem hiding this comment.
Fix it in a different way. Changed it to unordered list, because mdformat fails on this case.
Closed
rddimon
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pre-commit as a replacement for tox linting: