Handle dot index#36
Closed
arielkru wants to merge 7 commits into
Closed
Conversation
|
Hi @jconstance-amplify , @aoskotsky-amplify |
hi117
reviewed
Jul 27, 2020
| attr_splat_expr_term : expr_term attr_splat | ||
| full_splat_expr_term : expr_term full_splat | ||
| index : "[" new_line_or_comment? expression new_line_or_comment? "]" | ||
| index : "[" new_line_or_comment? expression new_line_or_comment? "]" | "." DECIMAL |
There was a problem hiding this comment.
This should be DECIMAL+ since there might be lists of length greater than 10
Handle indexes of lists with more than 10 items
|
It would be awesome if it was possible to get a release with this fix... Would solve some issues I am currently facing when using this library. |
Member
|
Hey, thanks for the PR. I pulled it and cleaned a few things up in a new one #44. I'll have it merged soon |
Member
|
Should be fixed now with #44. Let me know if there are any issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle index pattern
.intin addition to[int]Solves bridgecrewio/checkov#355
@aoskotsky-amplify