Stop transforming attributes into lists#73
Merged
aoskotsky-amplify merged 1 commit intoJul 14, 2021
Merged
Conversation
It was treating attributes in the same way as blocks, wrapping them in lists. This change makes it follow the spec and treat attributes like simple key/values. This seems like a major breaking change for anything using this library. Fixes amplify-education#6
aoskotsky-amplify
approved these changes
Jul 14, 2021
aoskotsky-amplify
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. The change looks great! I'll merge and bump the version to 3.0.0 because it's a breaking change
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was treating attributes in the same way as blocks, wrapping them in lists. This change makes it follow the spec and treat attributes like simple key/values.
This seems like a major breaking change for anything using this library.
Fixes #6