Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

kristoferbaxter
Copy link
Contributor

It's not currently possible to preloadExtension within a child iframe. This PR was always installing on the parent frame.

@kristoferbaxter kristoferbaxter merged commit 933c001 into ampproject:master Aug 10, 2020
@kristoferbaxter kristoferbaxter deleted the revert-polyfill-animations branch August 10, 2020 23:28
kristoferbaxter added a commit that referenced this pull request Aug 10, 2020
calebcordry pushed a commit that referenced this pull request Aug 11, 2020
* Revert polyfill web animations lazily due to issue with FIE
* Type was wrong

(cherry picked from commit 933c001)
kristoferbaxter added a commit that referenced this pull request Aug 11, 2020
* Revert "⏪ Temporarily revert lazy polyfill web animations (#29772)"

This reverts commit 933c001.

* Install polyfill into child window

* Update install-polyfill.js

Cleanup

Co-authored-by: Justin Ridgewell <[email protected]>
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
* Revert polyfill web animations lazily due to issue with FIE
* Type was wrong
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
…t#29775)

* Revert "⏪ Temporarily revert lazy polyfill web animations (ampproject#29772)"

This reverts commit 933c001.

* Install polyfill into child window

* Update install-polyfill.js

Cleanup

Co-authored-by: Justin Ridgewell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants