Sync from Google #29870
Merged
Sync from Google #29870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 327119354
|
Hey @ampproject/wg-caching! These files were changed: |
…nt in parser not to use temporary. This fix the fuzz test asan error. - The testdata/* doesn't work as it contains .dat (binary files) and parser always fails (crashes) for non-text files. Copied some test dataset from similar project which seems to be working and well tested. - After running parser on binary content, we saw a few generally unreachable code triggering runtime exceptions in the form of LOG(FATAL) statements. Supress such exceptions by replacing invalid utf8 char with replacement character \U+FFFD This remove one more exception that may potentially terminate servers for one bad document. PiperOrigin-RevId: 327121381
amaltas
approved these changes
Aug 17, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* Internal Refactoring PiperOrigin-RevId: 327119354 * - Fix ASAN error memory accessed after its freed error. Updated comment in parser not to use temporary. This fix the fuzz test asan error. - The testdata/* doesn't work as it contains .dat (binary files) and parser always fails (crashes) for non-text files. Copied some test dataset from similar project which seems to be working and well tested. - After running parser on binary content, we saw a few generally unreachable code triggering runtime exceptions in the form of LOG(FATAL) statements. Supress such exceptions by replacing invalid utf8 char with replacement character \U+FFFD This remove one more exception that may potentially terminate servers for one bad document. PiperOrigin-RevId: 327121381 Co-authored-by: Amaltas Bohra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request.