Snap to the correct slide on orientationChange.#5120
Merged
Conversation
2ce8e9e to
e4d3472
Compare
Contributor
|
Looks good, but please add test specifically for orientation change part. |
e4d3472 to
d6c183a
Compare
Contributor
Author
|
PTAL |
Contributor
|
LGTM |
dvoytenko
approved these changes
Sep 20, 2016
mityaha
pushed a commit
to brightcove-archive/ooyala_amphtml
that referenced
this pull request
Nov 30, 2016
* Snap to the correct slide on orientationChange. * Add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5096