Implementation and documentation of AdvertServe <amp-ad> tag#5366
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
CLAs look good, thanks! |
|
/to @lannka |
lannka
left a comment
There was a problem hiding this comment.
Look good in general.
We recommend all ad networks to implement our new render-start API, see development guidelines for details?
| data-client="tester" | ||
| data-pid=0 | ||
| data-zid=68> | ||
| <div placeholder></div> |
There was a problem hiding this comment.
please add the <fallback> tag as well.
| data-adtest="1"> | ||
| </amp-ad> | ||
|
|
||
| <h2>AdvertServe</h2> |
There was a problem hiding this comment.
no change needed in this file
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
CLAs look good, thanks! |
|
Ok, I've removed my changes to examples/ads-legacy.amp.html and added the fallback tag as requested. I have also implemented the renderStart, noContentAvailable and reportRenderedEntityIdentifier APIs. |
lannka
left a comment
There was a problem hiding this comment.
Awesome! It works great. But please resolve the merge conflict so that I can help to merge.
|
Thanks, I've resolved the merge conflicts. |
…ect#5366) * Implementation and documentation of AdvertServe <amp-ad> tag * Implementation and documentation of AdvertServe <amp-ad> tag * Removed changes that weren't needed * Added the <fallback> tag * Implemented renderStart
…ect#5366) * Implementation and documentation of AdvertServe <amp-ad> tag * Implementation and documentation of AdvertServe <amp-ad> tag * Removed changes that weren't needed * Added the <fallback> tag * Implemented renderStart
Here is my implementation and documentation of the
amp-adtag for @AdvertServe as indicated in #5364Fixes #5364.