Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Updating sorting logic in UserPreferencesRepository #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: preferences_datastore
Choose a base branch
from
Open

Updating sorting logic in UserPreferencesRepository #32

wants to merge 1 commit into from

Conversation

anidhamal
Copy link

Issue

Fixes #31

Description

  • Inside enableSortByPriority / enableSortByDeadline methods , checking if the argument is true and SortOrder is already BY_DEADLINE_AND_PRIORITY, perform no updates in preferences.

Videos

Before After

Arrowsome
Arrowsome reviewed Feb 8, 2022
View reviewed changes
Copy link

@Arrowsome Arrowsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using if blocks, you could use when statement, which IMO makes the code more clear, example for enableSortByPriority method:

if (enable) {
  when (currentOrder) {
    SortOrder.BY_DEADLINE -> SortOrder.BY_DEADLINE_AND_PRIORITY
    SortOrder.NONE -> SortOrder.BY_PRIORITY
    else -> return@edit
  } else {
    // same as before
  }
}

@mmoczkowski mmoczkowski self-requested a review October 3, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmoczkowski mmoczkowski Awaiting requested review from mmoczkowski

2 more reviewers

@Arrowsome Arrowsome Arrowsome left review comments

@ItsTheBacon ItsTheBacon ItsTheBacon approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anidhamal @Arrowsome @ItsTheBacon