Remove platform-specific implementation of createApi in Factory #101
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @Sushant-Hande, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request streamlines the dependency injection setup by removing an unnecessary expect/actual pattern for the createApi function. By centralizing this function in common code, it reduces code duplication and simplifies the overall architecture without introducing any functional changes.
Highlights
- Factory Class Refactoring: The Factory class has been refactored to eliminate the expect/actual mechanism previously used for the createApi function.
- Centralized createApi Implementation: The createApi function is now implemented as a standard function directly within the common code, leveraging commonCreateApi.
- Removal of Platform-Specific Code: All platform-specific actual implementations of createApi have been removed from androidMain and iosMain source sets, simplifying the codebase.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request is a nice simplification that removes the unnecessary expect/actual mechanism for createApi. The changes are straightforward and achieve the goal described. I have one suggestion in AppContainer.kt to further improve encapsulation by inlining the API creation logic, which would make the AppContainer more self-contained.
Fruitties/shared/src/commonMain/kotlin/com/example/fruitties/di/AppContainer.kt
Show resolved
Hide resolved
…ntralize JSON configuration
| object JsonConfig { | ||
| val json = Json { ignoreUnknownKeys = true } | ||
| } |
There was a problem hiding this comment.
nit: I'd say we can keep it in the AppContainer file and just use it without the object.
There was a problem hiding this comment.
Yeah that would also work. Let me do the change.
There was a problem hiding this comment.
@mlykotom Thanks for your review. I have implemented the suggested change.
|
@mlykotom I have addressed the formatting issue. |
Summary
Motivation
Impact