Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP] Draft Nav3 migration (from Don) #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[WIP] Draft Nav3 migration (from Don) #1904

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
14d7d20
Refactor :bookmarks into :bookmarks:impl
dturner Jul 1, 2025
8d7befb
Add :bookmarks:api module
dturner Jul 1, 2025
f024e28
Add Nav3 dependencies, :core:navigation and NavDisplay
dturner Jul 1, 2025
995e1ab
Mirroring Nav2 back stack state
dturner Jul 7, 2025
16d8d46
Adding conversion from NavBackStackEntry to route instance
dturner Jul 8, 2025
ba07375
Allow new routes to be pushed onto the back stack
dturner Jul 9, 2025
6ebf665
Finish refactor of api/impl
dturner Jul 9, 2025
1e30bc4
Migrate topic feature to Nav3
dturner Jul 9, 2025
ae8c462
Migrate search feature
dturner Jul 9, 2025
e196be9
Migrate interests feature
dturner Jul 9, 2025
3a40f1b
Support nested nav graphs
dturner Jul 15, 2025
572aaed
Tidy up
dturner Jul 15, 2025
ec2b09c
Migrate ForYou feature to Nav3
dturner Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add :bookmarks:api module
  • Loading branch information
@dturner
dturner committed Jul 1, 2025
commit 8d7befb2587cc90b38c7d5969143a800db4dc6bf
2 changes: 1 addition & 1 deletion app/src/androidTest/kotlin/com/google/samples/apps/nowinandroid/ui/NavigationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ import org.junit.Before
import org.junit.Rule
import org.junit.Test
import javax.inject.Inject
import com.google.samples.apps.nowinandroid.feature.bookmarks.R as BookmarksR
import com.google.samples.apps.nowinandroid.feature.bookmarks.impl.R as BookmarksR
import com.google.samples.apps.nowinandroid.feature.foryou.R as FeatureForyouR
import com.google.samples.apps.nowinandroid.feature.search.R as FeatureSearchR
import com.google.samples.apps.nowinandroid.feature.settings.R as SettingsR
Expand Down
1 change: 1 addition & 0 deletions feature/bookmarks/api/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/build
28 changes: 28 additions & 0 deletions feature/bookmarks/api/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
/*
* Copyright 2025 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

plugins {
alias(libs.plugins.nowinandroid.android.library)
alias(libs.plugins.kotlin.serialization)
}

android {
namespace = "com.google.samples.apps.nowinandroid.feature.bookmarks.api"
}

dependencies {
implementation(libs.kotlinx.serialization.json)
}
17 changes: 17 additions & 0 deletions feature/bookmarks/api/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="utf-8"?>
<!--
Copyright 2025 The Android Open Source Project

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<manifest />
1 change: 1 addition & 0 deletions settings.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ include(":core:ui")

include(":feature:foryou")
include(":feature:interests")
include(":feature:bookmarks:api")
include(":feature:bookmarks:impl")
include(":feature:topic")
include(":feature:search")
Expand Down