Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Some migration scans the entire project even when not needed #61039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Francesco-Borzi opened this issue Apr 29, 2025 · 2 comments
Open

Some migration scans the entire project even when not needed #61039

Francesco-Borzi opened this issue Apr 29, 2025 · 2 comments
Labels
area: migrations Issues related to `ng update` migrations
Milestone

Comments

@Francesco-Borzi
Copy link

Which @angular/* package(s) are the source of the bug?

core

Is this a regression?

Yes

Description

I have a large Angular project split into libraries using NX.

When I use this migration script specifying:

when I specify the path of the directory I want to migrate, it works as expected.

However, when I use other migration scripts such as:

even though I try to use it by passing a specific directory path, it starts scanning the entire project and at some points it runs out of memory.

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

The problem is that it tries to scan the entire project even when it's not needed because a path is specified.

Please note that this only affects SOME migration scripts (e.g. self-closing tag) while other (e.g. control-flow migration) do not have this issue.

Please provide the environment you discovered this bug in (run ng version)

Angular CLI: 19.2.5
Node: 22.14.0
Package Manager: npm 10.9.2
OS: darwin arm64

Angular: 19.2.4
... animations, common, compiler, compiler-cli, core, forms
... language-service, localize, platform-browser
... platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1902.5
@angular-devkit/build-angular   19.2.5
@angular-devkit/core            19.2.5
@angular-devkit/schematics      19.2.5
@angular/cdk                    19.2.7
@angular/cli                    19.2.5
@schematics/angular             19.2.5
ng-packagr                      19.2.0
rxjs                            7.8.2
typescript                      5.8.2
zone.js                         0.15.0

Anything else?

No response

@JeanMeche
Copy link
Member

This is likely a duplicate of #59813. #60774 landed an improvement for this, but only on the next major (v20).

@JoostK
Copy link
Member

JoostK commented Apr 29, 2025

This is likely a duplicate of #59813. #60774 landed an improvement for this, but only on the next major (v20).

It was backported to v19 in #60776, released in 19.2.6 (so not present in the user's report.

@pkozlowski-opensource pkozlowski-opensource added the area: migrations Issues related to `ng update` migrations label Apr 30, 2025
@ngbot ngbot bot added this to the needsTriage milestone Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: migrations Issues related to `ng update` migrations
Projects
None yet
Development

No branches or pull requests

4 participants