Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test(ivy): re-enable passing tests and misc cleanup #28093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test(ivy): re-enable passing tests and misc cleanup #28093

wants to merge 1 commit into from

Conversation

kara
Copy link
Contributor

@kara kara commented Jan 12, 2019

No description provided.

@kara kara requested review from a team as code owners January 12, 2019 00:46
@mary-poppins
Copy link

You can preview 6ce0bf0 at https://pr28093-6ce0bf0.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 4053c81 at https://pr28093-4053c81.ngbuilds.io/.

@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Jan 12, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jan 12, 2019
AndrewKushnir
AndrewKushnir approved these changes Jan 12, 2019
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kara kara added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 12, 2019
@kara kara removed request for a team January 12, 2019 00:55
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
4 participants
@kara @mary-poppins @AndrewKushnir @googlebot