Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs(core): Mark TestBed.get as deprecated #32406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs(core): Mark TestBed.get as deprecated #32406

wants to merge 1 commit into from

Conversation

Goodwine
Copy link

We should now use TestBed.inject
See #32200

Fixes #26491

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe: Marked TestBed.get as @deprecated

What is the current behavior?

TestBed.get is usable

Issue Number: #26491

What is the new behavior?

TestBed.get is usable BUT deprecated.
We should now use TestBed.inject from Angular 9.0.0+

Does this PR introduce a breaking change?

  • Yes
  • No

Not a breaking change but it will affect linters until users migrate, it should be a warning, not a failure.

Other information

@Goodwine Goodwine requested review from a team as code owners August 29, 2019 21:21
@mhevery mhevery self-assigned this Sep 3, 2019
@mhevery mhevery added the area: core Issues related to the framework runtime label Sep 3, 2019
@ngbot ngbot bot added this to the needsTriage milestone Sep 3, 2019
@vikerman
Copy link
Contributor

vikerman commented Sep 6, 2019

I would actually call this out as feat(core): TestBed.get is now deprecated in the commit message. And mention the alternative in the commit message

@Goodwine
Copy link
Author

Goodwine commented Sep 6, 2019

I would actually call this out as feat(core): TestBed.get is now deprecated in the commit message.

Done

And mention the alternative in the commit message

It was already mentioned, but reworded now

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Sep 9, 2019
@ngbot
Copy link

ngbot bot commented Sep 9, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: test_docs_examples_ivy" is failing
    pending status "google3" is pending
    pending missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@Goodwine
feat(core): Deprecate TestBed.get as deprecated
14c996e 
From 9.0.0 use TestBed.inject
See #32200

Fixes #26491
@Goodwine
Copy link
Author

Goodwine commented Sep 9, 2019

IDK why the test was failing, it didn't seem to be related to my change, but it looks like it's now passing after I sync'd

@matsko
Copy link
Contributor

matsko commented Sep 10, 2019

Presubmit = http://test/OCL:268199758:BASE:268199766:1568116843076:e43aaf3b

Ivy Presubmit = http://test/OCL:268199758:BASE:268199819:1568116873314:f0b6ce23

@mhevery mhevery added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 10, 2019
@mhevery
Copy link
Contributor

mhevery commented Sep 10, 2019

GLOBAL APPROVAL

@matsko matsko closed this in a85eccd Sep 12, 2019
@Goodwine Goodwine deleted the deprecate-testbed.get branch September 12, 2019 00:37
@timdeschryver timdeschryver mentioned this pull request Sep 12, 2019
Open
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@vikerman vikerman vikerman approved these changes

@mhevery mhevery mhevery approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mhevery mhevery

Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

Use typed get method in TestBed class
5 participants
@Goodwine @vikerman @matsko @mhevery @googlebot