Remove side effects to improve Ivy tree shaking in Closure #35846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inner function (angular#35769) This is useful for propagating return values without them being converted to a string. It still provides the same guarantees to Closure, which will assume that the function invoked is pure and can be tree-shaken accordingly. PR Close angular#35769 (cherry picked from commit 4052dd8)
…ular#35769) This causes all the `make*Decorator()` functions to be considered pure and to be eligible for associated tree shaking by Closure. PR Close angular#35769 (cherry picked from commit dc6a791)
) This marks the function are "pure" and eligible to be tree shaken by Closure. Without this, initializing `ngDevMode` is considered a side effect which prevents this function from being tree shaken and also any component which calls it. PR Close angular#35769 (cherry picked from commit ba36127)
…#35769) `ɵɵNgOnChangesFeature()` would set `ngInherit`, which is a side effect and also not necessary. This was pulled out to module scope so the function itself can be pure. Since it only curries another function, the call is entirely unnecessary. Updated the compiler to only generate a reference to this function, rather than a call to it, and removed the extra curry indirection. PR Close angular#35769 (cherry picked from commit 9cf85d2)
…r#35769) `ɵɵgetInheritedFactory()` is called from generated code for a component which extends another class. This function is detected by Closure to have a side effect and is not able to tree shake the component as a result. Marking it with `noSideEffects()` tells Closure it can remove this function under the relevant tree shaking conditions. PR Close angular#35769 (cherry picked from commit c195d22)
IgorMinar
approved these changes
Mar 6, 2020
matsko
pushed a commit
that referenced
this pull request
Mar 6, 2020
…inner function (#35769) (#35846) This is useful for propagating return values without them being converted to a string. It still provides the same guarantees to Closure, which will assume that the function invoked is pure and can be tree-shaken accordingly. PR Close #35769 (cherry picked from commit 4052dd8) PR Close #35846
matsko
pushed a commit
that referenced
this pull request
Mar 6, 2020
…35846) This marks the function are "pure" and eligible to be tree shaken by Closure. Without this, initializing `ngDevMode` is considered a side effect which prevents this function from being tree shaken and also any component which calls it. PR Close #35769 (cherry picked from commit ba36127) PR Close #35846
matsko
pushed a commit
that referenced
this pull request
Mar 6, 2020
…#35846) `ɵɵNgOnChangesFeature()` would set `ngInherit`, which is a side effect and also not necessary. This was pulled out to module scope so the function itself can be pure. Since it only curries another function, the call is entirely unnecessary. Updated the compiler to only generate a reference to this function, rather than a call to it, and removed the extra curry indirection. PR Close #35769 (cherry picked from commit 9cf85d2) PR Close #35846
matsko
pushed a commit
that referenced
this pull request
Mar 6, 2020
#35846) `ɵɵgetInheritedFactory()` is called from generated code for a component which extends another class. This function is detected by Closure to have a side effect and is not able to tree shake the component as a result. Marking it with `noSideEffects()` tells Closure it can remove this function under the relevant tree shaking conditions. PR Close #35769 (cherry picked from commit c195d22) PR Close #35846
|
Landed as 000c834 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
N/A - No easy way to verify that Closure tree shakes the relevant functions.
No docs to update.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closure does not tree shake unused components built with Ivy.
Issue Number: http://b/149874196, http://b/149874638.
What is the new behavior?
Closure will now tree shake unused components built with Ivy.
Does this PR introduce a breaking change?
Other information
This is effectively identical to #35769, just targeting patch branch. I cherry-picked all the commits onto a new branch based on
9.0.x.