Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "fix(animations):..." commits that break internal tests #35847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Revert "fix(animations):..." commits that break internal tests #35847

wants to merge 2 commits into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Mar 4, 2020 •
edited
Loading

These commits cause internal tests to fail and are currently blocking g3 syncs.

atscott added 2 commits March 3, 2020 16:00
@atscott
Revert "fix(animations): allow computeStyle to work on elements creat…
848fd65 
…ed in Node (angular#35810)"

This reverts commit 17cf04e;
breaking internal tests.
@atscott
Revert "fix(animations): process shorthand margin and padding sty…
5ab5f0d 
…les correctly (angular#35701)"

This reverts commit 35c9f0d, breaks
internal tests
@pullapprove pullapprove bot requested review from gkalpak, kara and matsko March 4, 2020 00:04
@atscott atscott added the area: core Issues related to the framework runtime label Mar 4, 2020
@ngbot ngbot bot added this to the needsTriage milestone Mar 4, 2020
@atscott atscott added the target: patch This PR is targeted for the next patch release label Mar 4, 2020
@atscott atscott removed request for kara and gkalpak March 4, 2020 18:20
@pullapprove pullapprove bot requested review from gkalpak and kara March 4, 2020 18:21
@atscott atscott added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 4, 2020
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Mar 4, 2020
atscott added a commit that referenced this pull request Mar 4, 2020
@atscott
Revert "fix(animations): allow computeStyle to work on elements creat…
26dbefd 
…ed in Node (#35810)" (#35847)

This reverts commit 17cf04e;
breaking internal tests.

PR Close #35847
atscott added a commit that referenced this pull request Mar 4, 2020
@atscott
Revert "fix(animations): process shorthand margin and padding sty…
7a822d2 
…les correctly (#35701)" (#35847)

This reverts commit 35c9f0d, breaks
internal tests

PR Close #35847
@atscott atscott closed this in 3ce5be7 Mar 4, 2020
atscott added a commit that referenced this pull request Mar 4, 2020
@atscott
Revert "fix(animations): process shorthand margin and padding sty…
25ab464 
…les correctly (#35701)" (#35847)

This reverts commit 35c9f0d, breaks
internal tests

PR Close #35847
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matsko matsko matsko approved these changes

@gkalpak gkalpak Awaiting requested review from gkalpak

@kara kara Awaiting requested review from kara

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
3 participants
@atscott @matsko @googlebot