feat(ngcc): support JSON formatted console logging #35876
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stcom77
reviewed
Mar 5, 2020
alan-agius4
reviewed
Mar 5, 2020
There was a problem hiding this comment.
I think this is good. Though can we wait until we figure out how we are going to integrate this in the CLI. Since if it will not be used by the CLI, there would be no reason why these should be merged.
Thanks @petebacondarwin :)
gkalpak
approved these changes
Mar 5, 2020
d1c4e61 to
2d22dfd
Compare
|
Blocked on whether CLI actually needs it or not... |
This commit adds a `JsonConsoleLogger` that will format messages as JSON strings before writing them to the console. This should allow tools to parse the messages if running ngcc in a separate process. FW-1960
2d22dfd to
401ff51
Compare
|
Closing as this is no longer needed. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
Loggerthat will format messages as JSONstrings before writing them to the console. This should allow tools
to parse the messages if running ngcc in a separate process.
FW-1960
(I have set the target as "master-only" since this is arguably a new public API for ngcc, so I expect it to go into 9.1.0)