fix(language-service): resolve the real path for symlink #35895
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayazhafiz
approved these changes
Mar 6, 2020
ivanwonder
commented
Mar 6, 2020
when AOT resolves the module name, it will preserve the path of the symlink, but the ts-server will return the real path for symlink.
1194096 to
fd4aca5
Compare
ayazhafiz
approved these changes
Mar 6, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when AOT resolves the module name, it will preserve the path of the symlink (because of no
host.realpath), but the ts-server will return the real path for symlink(https://github.com/angular/vscode-ng-language-service/blob/9120631a10fc9d49b4dd16c9976cc4222b98f3ff/server/src/server_host.ts#L132).I don't know if it needs a test case.
fixed: angular/vscode-ng-language-service#657
https://github.com/microsoft/TypeScript/blob/6769313eee2f2403387ea935a4fef4dfddae7671/src/compiler/moduleNameResolver.ts#L951
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information